Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally install PDB files when building them #7626

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Dec 9, 2024

would allow installing PDB files when doing Windows builds producing debug symbols

@mgallien mgallien added this to the 3.15.1 milestone Dec 9, 2024
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds are failing across the board, maybe we can also limit to Windows?

@mgallien mgallien force-pushed the feature/installPdbSymbolFilesOnWindows branch from c6e8339 to 32d6bbb Compare December 11, 2024 18:05
@mgallien mgallien requested a review from claucambra December 11, 2024 18:05
@mgallien mgallien force-pushed the feature/installPdbSymbolFilesOnWindows branch from 32d6bbb to 6ba4208 Compare December 12, 2024 07:57
would allow installing PDB files when doing Windows builds producing
debug symbols

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the feature/installPdbSymbolFilesOnWindows branch from 6ba4208 to be85f3c Compare December 12, 2024 09:08
@mgallien mgallien enabled auto-merge December 12, 2024 09:08
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7626-be85f3c1ec494f96cdb4d417e1f4b4b678b7074b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Dec 12, 2024

@mgallien mgallien disabled auto-merge December 12, 2024 09:46
@mgallien mgallien merged commit 2badd54 into master Dec 12, 2024
14 of 16 checks passed
@mgallien mgallien deleted the feature/installPdbSymbolFilesOnWindows branch December 12, 2024 09:46
@mgallien
Copy link
Collaborator Author

/backport to stable-3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants